[Hotfix] Handle missing data #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not just None but also NaN (in cases a column is misidentified as float
harisang
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how missing data for reward targets is identified. It fixes a bug where missing data causes the script to crash.
The issue seems to come from a column without valid values being misidentified as float column and the missing value is encoded as
NaN. This was not identified as missing data since it only checks forNone.With this PR, the pandas function
isnais used to identify missing data.A similar approach was used in #435.
Since local tests are still running, I created this as draft PR. I will remove the draft status once the local run is successful.