Use mainnet dai price for xdai #457
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the price feed for xDAI on Gnosis to the one for DAI on mainnet.
There is a discrepancy of around 1% between the dai (0.999917) and xdai (1.008912) price on coin paprika on 2024-12-09.
Since Dune seems to be using the DAI price for WXDAI, there is a discrepancy between conversions done on Dune and conversions done in the payout script.
This change does not make the payout more accurate. But it makes it easier to check payments against the corresponding Dune dashboards.
It is still up to an internal discussino if this should be merged.