Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce manual price corrections table #504

Merged
merged 21 commits into from
Feb 3, 2025

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Jan 28, 2025

This PR is a simplification of PR #498 , where we skip the analytics db and directly store the corrections in a file in this repo.

To identify problematic txs, i used this Dune query

select
    environment,
    auction_id,
    tx_hash,
    protocol_fee / pow(10,18) as protocol_fee_in_eth,
    network_fee / pow(10,18) as network_fee_in_eth
from
    "query_4351957(blockchain='ethereum')"
where
    network_fee / pow(10, 18) > 10
    or protocol_fee / pow(10, 18) > 10
order by
    auction_id desc

@harisang
Copy link
Contributor Author

harisang commented Feb 2, 2025

@fhenneke A quick and somewhat sloppy way to test the code is to look at
3cbe5be

and then look at the follow-up commits that add a corrected price at the auction_prices_corrections.sql file, so that the test passes again.

Not the best way to test things, but at least it shows some things

@harisang harisang requested a review from fhenneke February 2, 2025 23:16
Copy link
Collaborator

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we need reasonable test. Leaking test code into production is quite sketchy.

@harisang harisang merged commit be8716d into main Feb 3, 2025
6 checks passed
@harisang harisang deleted the introduce_native_price_corrections branch February 3, 2025 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants