Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coingecko list to gnosis chain #380

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

shoom3301
Copy link
Contributor

In a similar way with GnosisUniswapTokensList.json I added GnosisCoingeckoTokensList.json which is derived from CoinGecko.json.

The CoinGecko.json is a bit outdated, because coingecko.ts script fails after 3 pages fetching with 429 error from Coingecko API.

To solve this, I did:

  1. Added the json file to the repo in public directory
  2. Manually ran coingecko.ts two times, 1st time for 1-3 pages and second time for 3-5 pages (under VPN to bypass the API limitation)

Before the update the list contained 243 tokens, now 288.

@shoom3301 shoom3301 requested a review from a team April 17, 2024 12:30
@shoom3301 shoom3301 self-assigned this Apr 17, 2024
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just a few minor comments

src/public/CoinGecko.json Outdated Show resolved Hide resolved
src/public/GnosisUniswapTokensList.json Show resolved Hide resolved
@shoom3301 shoom3301 merged commit 7700d93 into main Apr 19, 2024
5 checks passed
@shoom3301 shoom3301 deleted the feat/coingecko-gnosis-chain branch April 19, 2024 07:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Cool!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants