-
Notifications
You must be signed in to change notification settings - Fork 659
[feat][backend] ob add manual annotation #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… DAO implementation (LogID: 202509101633310100911112096963473) Co-Authored-By: Coda <[email protected]>
(LogID: 202509101633310100911112096963473) Co-Authored-By: Coda <[email protected]>
…om commercial version (LogID: 202509101633310100911112096963473) Co-Authored-By: Coda <[email protected]>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (29.18%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 58.20% 58.68% +0.48%
==========================================
Files 511 512 +1
Lines 53355 53515 +160
==========================================
+ Hits 31055 31405 +350
+ Misses 19919 19719 -200
- Partials 2381 2391 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
QueryTypeGetTrace = "get_trace" | ||
QueryTypeListSpans = "list_spans" | ||
|
||
// 人工标注标签 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个在repo层有点怪,能不能上移
return nil, errorx.WrapByCode(err, obErrorx.CommercialCommonRPCErrorCodeCode) | ||
} | ||
for _, span := range spans { | ||
span.SystemTagsString[loop_span.SpanFieldTenant] = "cozeloop" // tenant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是干嘛的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要知道annotation往哪张表上写
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: