Skip to content

Conversation

kidkidkid
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

kidkidkid and others added 7 commits September 10, 2025 16:48
… DAO implementation

(LogID: 202509101633310100911112096963473)

Co-Authored-By: Coda <[email protected]>
(LogID: 202509101633310100911112096963473)

Co-Authored-By: Coda <[email protected]>
…om commercial version

(LogID: 202509101633310100911112096963473)

Co-Authored-By: Coda <[email protected]>
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 29.18033% with 216 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../modules/observability/infra/repo/ck/annotation.go 0.00% 118 Missing ⚠️
...ckend/modules/observability/infra/repo/ck/spans.go 47.59% 80 Missing and 18 partials ⚠️

❌ Your patch check has failed because the patch coverage (29.18%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   58.20%   58.68%   +0.48%     
==========================================
  Files         511      512       +1     
  Lines       53355    53515     +160     
==========================================
+ Hits        31055    31405     +350     
+ Misses      19919    19719     -200     
- Partials     2381     2391      +10     
Flag Coverage Δ
unittests 58.68% <29.18%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckend/modules/observability/infra/repo/ck/spans.go 43.16% <47.59%> (+4.03%) ⬆️
.../modules/observability/infra/repo/ck/annotation.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2a854...d74b6ea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

QueryTypeGetTrace = "get_trace"
QueryTypeListSpans = "list_spans"

// 人工标注标签
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个在repo层有点怪,能不能上移

return nil, errorx.WrapByCode(err, obErrorx.CommercialCommonRPCErrorCodeCode)
}
for _, span := range spans {
span.SystemTagsString[loop_span.SpanFieldTenant] = "cozeloop" // tenant
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是干嘛的

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要知道annotation往哪张表上写

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants