WIP: Migrate from cozy-client-js to cozy-client #2375
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
chore/replace-cozy-client-js-with-cozy-client
branch
from
e2bc55d to
cce70f3
Compare
taratatach
force-pushed
the
chore/replace-cozy-client-js-with-cozy-client
branch
4 times, most recently
from
6d9780b to
2d5fdbb
Compare
taratatach
force-pushed
the
chore/replace-cozy-client-js-with-cozy-client
branch
3 times, most recently
from
0e58346 to
870de5b
Compare
This version brings the necessary features to switch from `cozy-client-js` to `cozy-client` entirely.
When a local file move to a destination where a file already exists is converted into an update of the existing file, if the existing and moved files have the exact same modification date then the modification will be ignored and not saved in PouchDB. This choice was made on purpose to avoid merging intermediary file changes in some situations like the propagation of a remote change to the local filesystem. Although having the exact same modification date for 2 files should be almost impossible in production, it can quite easily happen in tests where documents and their metadata are generated very closely. This was the case in the unit test for this specific situation which was failing from time to time (more often on the CI).
Upgrade `pouchdb-find` and `pouchdb-adapter-memory` as well since they're linked. We change the way we handle the `_rev` attribute when creating views as the revision validation code has changed in PouchDB v9.
taratatach
force-pushed
the
chore/replace-cozy-client-js-with-cozy-client
branch
from
870de5b to
d9098b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked: