[VO-421] fix: Taking account of feedback following the migration of apps to 11 #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
force-pushed
the
fix/v11-migration-returns
branch
from
ebe0a4f to
1792480
Compare
JF-Cozy
approved these changes
Feb 28, 2024
| const appReducer = combineReducers(reducers) | ||
| ``` | ||
|
|
||
| If you did not provide a custom store to cozy-client, you may need to add the `store: true` option when setting up your CozyClient to ensure that it has a store. This was previously done as a side effect in cozy-bar v7. |
There was a problem hiding this comment.
on devrait mettre plus en avant ce cas, peut-être avec un exemple de code qui fait l'init de cozy-client avec cet attr à true, ça saute plus aux yeux je trouve.
There was a problem hiding this comment.
Ok je vais rajouter ça
This example was out of date with the new version. The next step is to add storybook to make a documentation page.
BREAKING CHANGE : You must have cozy-client >= 45.13.0
BREAKING CHANGE : You must have cozy-ui >= 103.7.0
The CSS preprocessor put an underscore before the double hyphen, making the classes obsolete. I followed the BEM convention and modified it to have a distinct class
cballevre
force-pushed
the
fix/v11-migration-returns
branch
from
1792480 to
bf37f2e
Compare
cballevre
changed the title
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.