Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add client_side attribute to manifests #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doubleface
Copy link
Contributor

In replacement of clientSide since snake case is the norm.
clientSide is deprecated

See #221 (comment)

Thanks for contributing to this documentation. If you added a doctype, please be sure that it is present

In replacement of `clientSide` since snake case is the norm.
clientSide is deprecated
@doubleface doubleface requested a review from Crash-- February 14, 2023 13:46
@Crash--
Copy link
Contributor

Crash-- commented Feb 14, 2023

No way we handle the both versions. Either we change it and break the thing right now or we do nothing.

@Crash--
Copy link
Contributor

Crash-- commented Mar 15, 2023

ping @doubleface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants