Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): Improve speed of search suggestions #2675

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

trollepierre
Copy link
Contributor

@trollepierre trollepierre commented Aug 24, 2022

By preventing every notes fetching url, loading only once a note is clicked

Last question: should we update isNote in cozy-client? (I think yes, but I will confirm)

after #2663 (comment)

@trollepierre trollepierre marked this pull request as draft August 24, 2022 13:47
@bundlemon
Copy link

bundlemon bot commented Aug 24, 2022

BundleMon

Unchanged files (10)
Status Path Size Limits
public/drive.(hash).js
1.46MB 1.6MB
vendors/drive.(hash).js
1.4MB 1.54MB
services/dacc/drive.js
248.51KB 249KB
services/qualificationMigration/drive.js
243.42KB 244KB
app/drive.(hash).js
233.23KB 234KB
public/pdf.worker.entry.(hash).worker.js
220.57KB 221KB
public/drive.(hash).min.css
85.57KB 86KB
app/drive.(hash).min.css
54.6KB 55KB
vendors/drive.(hash).(hash).min.css
34.38KB 35KB
public/cozy-bar.css
18.42KB 24KB

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Crash--
Copy link
Contributor

Crash-- commented Aug 24, 2022

For this PR we don't need to change the behavior of the isNote method since we don't change the way we fetch the data ;)

@trollepierre trollepierre force-pushed the note-search branch 2 times, most recently from 43ff6fc to 0c34fd6 Compare August 25, 2022 08:51
@trollepierre trollepierre marked this pull request as ready for review August 25, 2022 08:58
Copy link
Member

@Ldoppea Ldoppea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code part looks good to me. However I'm not confident enough to review the logic part and all implications, so consider my approval only for the code structure part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants