Feat/welcome cozy pass web #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
commented
Mar 30, 2023
Ldoppea
reviewed
Mar 31, 2023
Ldoppea
reviewed
Mar 31, 2023
Crash--
reviewed
Mar 31, 2023
Crash--
reviewed
Mar 31, 2023
Crash--
reviewed
Mar 31, 2023
|
nit: For more clarity, instead of At that time the only way to access CozyPass was to use the browser extension, so we used that value to check if the extension was installed or not. Today the extension is not a requirement anymore, so we suggest to install it but the user can skip this step and log from the web interface instead (or from the mobile app). Login to the web is enough to have We still use the |
zatteo
force-pushed
the
feat/welcome-cozy-pass-web
branch
2 times, most recently
from
2fbf8a7 to
0973003
Compare
zatteo
force-pushed
the
feat/welcome-cozy-pass-web
branch
from
0973003 to
c458272
Compare
passwords fetch data with { mode: 'no-cors' } which does not work with
httpServer
- SettingsCollection.get quick fix for io.cozy.settings.bitwarden - isNativePassInstalledOnDevice type
zatteo
force-pushed
the
feat/welcome-cozy-pass-web
branch
from
9bb7a5b to
f206b18
Compare
zatteo
force-pushed
the
feat/welcome-cozy-pass-web
branch
from
f206b18 to
3521009
Compare
Crash--
approved these changes
Apr 3, 2023
Ldoppea
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we open
passwords, if no extension is installed, we open cozy-pass-web inside the flagship app to show the onboarding. If extension is installed, we keep calling openAppNative to open native app (or the store).