feat: Enable InlineMenuFieldQualification flag for better login quali…

…fication
cozy · Dec 5, 2024 · 7b519ac · 7b519ac
1 parent b9b3790
commit 7b519ac
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts b/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
@@ -1459,9 +1459,22 @@ export class InlineMenuFieldQualificationService
       const checkedAttributeValue = checkedAttributeValues[i];
       const cleanedValue = checkedAttributeValue?.toLowerCase().replace(/[\s_-]/g, "");
 
+      // Cozy customization, this method is called because we enabled InlineMenuFieldQualification but
+      // it is too strict and gives false positive like when a password htmlName is "p"
+      //*
+      if (
+        cleanedValue &&
+        AutoFillConstants.FieldIgnoreList.some(
+          (fieldIgnore) => cleanedValue.indexOf(fieldIgnore) > -1,
+        )
+      ) {
+        return true;
+      }
+      /*/
       if (cleanedValue && this.fieldIgnoreListString.indexOf(cleanedValue) > -1) {
         return true;
       }
+      //*/
     }
 
     return false;

diff --git a/libs/common/src/enums/feature-flag.enum.ts b/libs/common/src/enums/feature-flag.enum.ts
@@ -65,7 +65,12 @@ export const DefaultFeatureFlagValue = {
   [FeatureFlag.PM4154_BulkEncryptionService]: FALSE,
   [FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE,
   [FeatureFlag.EmailVerification]: FALSE,
+  // Cozy customization, enable enhanced login detection in inline menu
+  //*
+  [FeatureFlag.InlineMenuFieldQualification]: true,
+  /*/
   [FeatureFlag.InlineMenuFieldQualification]: FALSE,
+  //*/
   [FeatureFlag.MemberAccessReport]: FALSE,
   [FeatureFlag.TwoFactorComponentRefactor]: FALSE,
   [FeatureFlag.EnableTimeThreshold]: FALSE,