fix: Open inline menu on focus if filled field only if settings is corresponding #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corresponding We customized the inline menu to open it on focus even if the field is filled. But we want to have this behavior only if the inline menu visibility is set to "On focus". If the inline menu visibility is set to "On button click" we want to keep the classic behavior.
Merkur39
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We customized the inline menu to open it on focus even if the field is filled. But we want to have this behavior only if the inline menu visibility is set to "On focus". If the inline menu visibility is set to "On button click" we want to keep the classic behavior.