fix: Use user locale on last konnector execution date (SCR-916) #2659
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doubleface
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
zatteo
as code owners
doubleface
force-pushed
the
fix/timeLocale
branch
from
925f35e to
18e8083
Compare
doubleface
force-pushed
the
fix/timeLocale
branch
from
18e8083 to
d2028c5
Compare
JF-Cozy
reviewed
Jan 16, 2025
| export const makeLabel = ({ t, konnector, trigger, isRunning, lang }) => { | ||
| if (lang) { | ||
| // force current language for cozy-ui formatLocallyDistanceToNow | ||
| initFormat(lang)(new Date(), 'yyyy-MM-dd HH:mm:ss') |
There was a problem hiding this comment.
ça me pose question cette approche 🤔 est-ce qu'on ne devrait pas plutôt passer lang à formatLocallyDistanceToNow @Merkur39 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force user locale used by cozy-ui's
formatLocallyDistanceToNowfunctionAvoid
Sync. Il y a about 23 hoursmessages