feat(sharing): Wip #2694
Draft
feat(sharing): Wip #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Merkur39
commented
Jan 10, 2025
•
Merkur39
commented
- Waiting feat(permissionColl & models/sharing): Improve sharing link feature cozy-client#1579
- Waiting Allow to patch password/expires_at for permissions cozy-stack#4506
Merkur39
force-pushed
the
feat/vo-1244
branch
2 times, most recently
from
abac7b1 to
f3d8620
Compare
Cozy-client has been updated, allowing us to make a few optimizations here. The `forwardFile` function has no place here, as it is only used on mobile (which is another component).
As we can't display the previously saved password, we'd like to display a specific placeholder that improves the UX. We'll also make sure that the password value is `“”` and not `undefined` when we deactivate it. This makes it clear to the stack that we want to delete the password and not keep it unchanged.
The user can find out as soon as he opens the sharing modal whether his link sharing is secure, and see its expiry date.
Merkur39
force-pushed
the
feat/vo-1244
branch
from
f3d8620 to
b83e5f0
Compare
Now that new attributes such as `expiresAt` and `password` exist, this has highlighted a bug due to the fact that the `updateSharingLink` parameter was wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.