Skip to content

Commit

Permalink
Remove OS in new connection emails
Browse files Browse the repository at this point in the history
The OS was guessed from the User-Agent, but the browsers have
implemented anti-fingerprinting measures that makes it more confusing
than helping for the user. The simpler is to remove it in emails.
  • Loading branch information
nono committed Jun 6, 2024
1 parent 7a2554f commit 9eae458
Show file tree
Hide file tree
Showing 9 changed files with 930 additions and 952 deletions.
3 changes: 0 additions & 3 deletions assets/locales/de.po
Original file line number Diff line number Diff line change
Expand Up @@ -715,9 +715,6 @@ msgstr "IP Adresse:"
msgid "Mail New Connection Browser"
msgstr "Browser:"

msgid "Mail New Connection OS"
msgstr "Gerät:"

msgid "Mail New Connection Change Passphrase instruction"
msgstr ""
"Wenn du hinter dieser neuen Verbindung steckst, kannst du diese Nachricht ignorieren und dein Cozy genießen.\n"
Expand Down
3 changes: 0 additions & 3 deletions assets/locales/en.po
Original file line number Diff line number Diff line change
Expand Up @@ -969,9 +969,6 @@ msgstr "IP Address:"
msgid "Mail New Connection Browser"
msgstr "Browser:"

msgid "Mail New Connection OS"
msgstr "Device:"

msgid "Mail New Connection Change Passphrase instruction"
msgstr ""
"If you are behind this new connection, you can ignore this message and enjoy your Cozy.\n"
Expand Down
3 changes: 0 additions & 3 deletions assets/locales/es.po
Original file line number Diff line number Diff line change
Expand Up @@ -717,9 +717,6 @@ msgstr "Dirección IP:"
msgid "Mail New Connection Browser"
msgstr "Navegador:"

msgid "Mail New Connection OS"
msgstr "Dispositivo:"

msgid "Mail New Connection Change Passphrase instruction"
msgstr ""
"Si está detrás de esta nueva conexión, puede ignorar este mensaje y disfrutar de su Cozy.\n"
Expand Down
3 changes: 0 additions & 3 deletions assets/locales/fr.po
Original file line number Diff line number Diff line change
Expand Up @@ -1065,9 +1065,6 @@ msgstr "Adresse IP :"
msgid "Mail New Connection Browser"
msgstr "Navigateur :"

msgid "Mail New Connection OS"
msgstr "Appareil :"

msgid "Mail New Connection Change Passphrase instruction"
msgstr ""
"Vous confirmez en être l’initiateur ? Si oui, profitez de ce nouvel accès !\n"
Expand Down
3 changes: 0 additions & 3 deletions assets/locales/ja.po
Original file line number Diff line number Diff line change
Expand Up @@ -580,9 +580,6 @@ msgstr "IP アドレス"
msgid "Mail New Connection Browser"
msgstr "ブラウザー"

msgid "Mail New Connection OS"
msgstr "オペレーティングシステム"

msgid "Mail New Connection Change Passphrase instruction"
msgstr ""
"あなたが行いましたか? すばらしいです! 安心しました。 ご不便おかけしてすみません。 "
Expand Down
3 changes: 0 additions & 3 deletions assets/locales/nl_NL.po
Original file line number Diff line number Diff line change
Expand Up @@ -902,9 +902,6 @@ msgstr "IP-adres:"
msgid "Mail New Connection Browser"
msgstr "Webbrowser:"

msgid "Mail New Connection OS"
msgstr "Apparaat:"

msgid "Mail New Connection Change Passphrase instruction"
msgstr ""
"Was je dit zelf? Dan kun je dit bericht negeren.\n"
Expand Down
1 change: 0 additions & 1 deletion assets/mails/new_connection.mjml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<li>{{t "Mail New Connection Place"}} {{.Country}}</li>
<li>{{t "Mail New Connection Time"}} {{.Time}}</li>
<li>{{t "Mail New Connection Browser"}} {{.Browser}}</li>
<li>{{t "Mail New Connection OS"}} {{.OS}}</li>
<li>{{t "Mail New Connection IP"}} {{.IP}}</li>
</ul>
</mj-text>
Expand Down
1 change: 0 additions & 1 deletion model/session/login_history.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ func sendLoginNotification(i *instance.Instance, l *LoginEntry) error {
"Country": l.Country,
"IP": l.IP,
"Browser": l.Browser,
"OS": l.OS,
"ChangePassphraseLink": changePassphraseLink,
"ActivateTwoFALink": activateTwoFALink,
}
Expand Down
1,862 changes: 930 additions & 932 deletions web/statik/statik.go

Large diffs are not rendered by default.

0 comments on commit 9eae458

Please sign in to comment.