fix: Fetch premium links status from config #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
fix/fetch-premium-links-status-from-config
branch
from
732e98c to
90549c4
Compare
nono
approved these changes
Sep 18, 2023
`enable_premium_links` is not a feature flag but actually a Context attribute which we can get from the config. Without this attribute, we would never show links to the manager's offers page when the limit of connected OAuth clients is exceeded.
taratatach
force-pushed
the
fix/fetch-premium-links-status-from-config
branch
from
90549c4 to
441477a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_premium_linksis not a feature flag but actually a Contextattribute which we can get from the config.
Without this attribute, we would never show links to the manager's
offers page when the limit of connected OAuth clients is exceeded.