fix: OAuth clients limit links open in current tab #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
reviewed
Sep 18, 2023
taratatach
force-pushed
the
fix/fetch-premium-links-status-from-config
branch
from
90549c4 to
441477a
Compare
Base automatically changed from
fix/fetch-premium-links-status-from-config
to
master
September 18, 2023 15:11
taratatach
force-pushed
the
fix/open-oauth-exceeded-links-in-same-tab-in-web
branch
from
b5d4192 to
fa80364
Compare
taratatach
changed the title
When the connected OAuth clients limit is reached on a Cozy, we display a blocking modal during the OAuth flow when trying to connect yet another client. In this situation we want the links displayed in the modal (i.e. to manage the connected clients or subscribe to another offer) to open in a new tab as this modal can be displayed in apps windows without any navigation means. However, when the modal is displayed when navigating in the Cozy in a browser because the limit has been exceeded, we don't have this limitation so the links should open in the same tab.
taratatach
force-pushed
the
fix/open-oauth-exceeded-links-in-same-tab-in-web
branch
from
fa80364 to
d191661
Compare
nono
approved these changes
Sep 18, 2023
taratatach
deleted the
fix/open-oauth-exceeded-links-in-same-tab-in-web
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the connected OAuth clients limit is reached on a Cozy, we
display a blocking modal during the OAuth flow when trying to connect
yet another client.
In this situation we want the links displayed in the modal (i.e. to
manage the connected clients or subscribe to another offer) to open in
a new tab as this modal can be displayed in apps windows without any
navigation means.
However, when the modal is displayed when navigating in the Cozy in a
browser because the limit has been exceeded, we don't have this
limitation so the links should open in the same tab.