fix: Clients limit exceeded route requires login #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
fix/require-login-for-oauth-clients-modal-page
branch
from
2b6aa5f to
c3c0de0
Compare
Settings tests' requests are all considered to have a session cookie which makes impossible to test the result of making a request as a logged-out user. To this end, we'll add the session to the request context only if a session cookie with a value of `connected` is present.
We should return an Unauthorized error when someone tries to access the clients limit exceeded route of a Cozy without a valid session (i.e. without being logged in).
taratatach
force-pushed
the
fix/require-login-for-oauth-clients-modal-page
branch
from
c3c0de0 to
fbf61b0
Compare
nono
approved these changes
Sep 27, 2023
taratatach
deleted the
fix/require-login-for-oauth-clients-modal-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should return an Unauthorized error when someone tries to access
the clients limit exceeded route of a Cozy without a valid session
(i.e. without being logged in).