fix: Preserve not_synchronized_on on shared dirs #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a member of a sharing modifies a directory within this sharing then the `io.cozy.files` doc on the other members' Cozy will lose their `not_synchronized_on` attribute. This means the directory will get synchronized with their Desktop client again while they haven't modified the configuration themselves. This is because we forgot to keep the existing attribute when updating the document in the sharing indexer.
taratatach
force-pushed
the
fix/keep-sync-exclusions-on-modified-shared-dirs
branch
from
1361377 to
099dc2d
Compare
taratatach
deleted the
fix/keep-sync-exclusions-on-modified-shared-dirs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a member of a sharing modifies a directory within this sharing
then the
io.cozy.filesdoc on the other members' Cozy will losetheir
not_synchronized_onattribute.This means the directory will get synchronized with their Desktop
client again while they haven't modified the configuration themselves.
This is because we forgot to keep the existing attribute when updating
the document in the sharing indexer.