Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linter to disable fmt.Printf in code #4154

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add a linter to disable fmt.Printf in code #4154

merged 1 commit into from
Oct 10, 2023

Conversation

nono
Copy link
Member

@nono nono commented Oct 9, 2023

Printf is often used while developping to inspect or debug code. It happens that these statements are forgotten and commited. We can prevent that by using a linter to disable them.

We have some cases where fmt.Printf was used to print useful stuff, like in the CLI. They have been rewritten in fmt.Fprintf to avoid been flagged by the linter.

Printf is often used while developping to inspect or debug code. It
happens that these statements are forgotten and commited. We can prevent
that by using a linter to disable them.

We have some cases where fmt.Printf was used to print useful stuff, like
in the CLI. They have been rewritten in fmt.Fprintf to avoid been
flagged by the linter.
@nono nono requested a review from a team as a code owner October 9, 2023 08:33
@nono nono merged commit 10923c7 into master Oct 10, 2023
6 checks passed
@nono nono deleted the no-printf branch October 10, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants