Fix a source of VFS inconsistencies #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CouchDB is using ICU algorithm for views and mango requests. It can be surprizing, and it was the source of a bug in the stack. When a directory 'EDF' is trashed, and a directory 'EDF⚡️' was nearby, the path of this directory can be incorrectly modified to be put in the trash. The system test 'filepath_operations.rb' was restored from a6a442b, and updated to test this new case.
taratatach
approved these changes
Oct 10, 2023
| folder = Folder.create inst, name: "EDF" | ||
| Folder.create inst, name: "EDF⚡️" | ||
| folder.remove inst | ||
| assert_equal inst.fsck, [] |
There was a problem hiding this comment.
Maybe we could also check that EDF⚡️ still exists?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CouchDB is using ICU algorithm for views and mango requests. It can be surprizing, and it was the source of a bug in the stack. When a directory 'EDF' is trashed, and a directory 'EDF⚡️' was nearby, the path of this directory can be incorrectly modified to be put in the trash.
The system test 'filepath_operations.rb' was restored from a6a442b, and updated to test this new case.