Fix a race condition #4160
Merged
Fix a race condition #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system test accounts_cleaning.rb has failed a couple of times on the CI. The reason is that it tries to clean two accounts for the same konnector at the same time, and both jobs need to recreate a work directory and update the permission of the konnector. There was a race condition, where it may happen that a conflict on the CouchDB document for the permissions makes one job to fail. A retry loop will fix this issue.
taratatach
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system test accounts_cleaning.rb has failed a couple of times on the CI. The reason is that it tries to clean two accounts for the same konnector at the same time, and both jobs need to recreate a work directory and update the permission of the konnector. There was a race condition, where it may happen that a conflict on the CouchDB document for the permissions makes one job to fail. A retry loop will fix this issue.