Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow app services to send marketing emails #4320

Merged
merged 5 commits into from
Feb 13, 2024
Merged

feat: Allow app services to send marketing emails #4320

merged 5 commits into from
Feb 13, 2024

Conversation

taratatach
Copy link
Member

Preserve mail server used for transactional emails from spam detection by
allowing webapps to send marketing emails via a dedicated mail server.

@taratatach taratatach self-assigned this Feb 7, 2024
@nono nono requested a review from sblaisot February 7, 2024 13:14
nono
nono reviewed Feb 7, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
pkg/emailer/init.go Outdated Show resolved Hide resolved
pkg/emailer/service.go Show resolved Hide resolved
web/jobs/jobs.go Outdated Show resolved Hide resolved
sblaisot
sblaisot requested changes Feb 7, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
pkg/mail/mail.go Outdated Show resolved Hide resolved
worker/mails/mail.go Outdated Show resolved Hide resolved
web/jobs/jobs.go Outdated Show resolved Hide resolved
@taratatach taratatach force-pushed the feat/offer-app-services-to-send-bulk-emails branch from b8c7411 to 0580496 Compare February 7, 2024 16:37
nono
nono reviewed Feb 7, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
web/jobs/jobs.go Outdated Show resolved Hide resolved
worker/mails/mail.go Outdated Show resolved Hide resolved
@taratatach taratatach force-pushed the feat/offer-app-services-to-send-bulk-emails branch 4 times, most recently from 04cb698 to a6782d8 Compare February 9, 2024 16:21
@taratatach taratatach marked this pull request as ready for review February 9, 2024 16:24
@taratatach taratatach requested a review from a team as a code owner February 9, 2024 16:24
@taratatach taratatach force-pushed the feat/offer-app-services-to-send-bulk-emails branch from a6782d8 to dc92e21 Compare February 9, 2024 16:24
@taratatach taratatach requested review from sblaisot and nono February 9, 2024 16:24
sblaisot
sblaisot reviewed Feb 10, 2024
View reviewed changes
Copy link
Contributor

@sblaisot sblaisot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice, if campaign_mail is not defined in config to use mail config as default.

This would ease usage on environments where specific non-transactional mail relays are not required, like on selfhosted environments.

docs/workers.md Outdated Show resolved Hide resolved
worker/mails/mail.go Outdated Show resolved Hide resolved
sblaisot
sblaisot reviewed Feb 10, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
cozy.example.yaml Outdated Show resolved Hide resolved
@sblaisot
Copy link
Contributor

It would be nice, if campaign_mail is not defined in config to use mail config as default.

said differently, what happen when sending campaign email if campaign_mail is not configured in cozy.yml?

sblaisot
sblaisot reviewed Feb 10, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
Crash--
Crash-- reviewed Feb 12, 2024
View reviewed changes
docs/jobs.md Outdated Show resolved Hide resolved
nono
nono reviewed Feb 12, 2024
View reviewed changes
cmd/serve.go Outdated Show resolved Hide resolved
nono
nono reviewed Feb 12, 2024
View reviewed changes
pkg/emailer/service_test.go Outdated Show resolved Hide resolved
nono
nono reviewed Feb 12, 2024
View reviewed changes
docs/jobs.md Outdated Show resolved Hide resolved
sblaisot
sblaisot reviewed Feb 12, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
sblaisot
sblaisot reviewed Feb 12, 2024
View reviewed changes
cozy.example.yaml Outdated Show resolved Hide resolved
@taratatach taratatach force-pushed the feat/offer-app-services-to-send-bulk-emails branch from c5fb3f3 to 0019d13 Compare February 12, 2024 15:33
@taratatach
feat: Add campaign emailer
b371379 
  Allows sending non transactional emails via a dedicated mail server to
  preserve the server used for transactional emails from spam detection.
@taratatach
test: Replace jobs tests deprecated matchers
6f0e757
@taratatach
feat: Pass Emailer service to jobs routes
21b188d 
  Use an HTTP handler in the `jobs` web package so we can pass it the
  Emailer service and use it in the route handlers.
@taratatach
feat: Add SendCampaignEmail method to Emailer
6a4d7bd 
  Add new method to the Emailer service to send non transactional emails
  via the dedicated campaign mail server.
@taratatach
feat: Add route to send campaign email from app
ada97fa
@taratatach taratatach force-pushed the feat/offer-app-services-to-send-bulk-emails branch from 0019d13 to ada97fa Compare February 12, 2024 15:45
@taratatach taratatach requested review from sblaisot and nono February 12, 2024 15:45
@taratatach taratatach merged commit 2c11baa into master Feb 13, 2024
4 checks passed
@taratatach taratatach deleted the feat/offer-app-services-to-send-bulk-emails branch February 13, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crash-- Crash-- Crash-- left review comments

@sblaisot sblaisot sblaisot approved these changes

@nono nono nono approved these changes

Assignees

@taratatach taratatach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taratatach @sblaisot @nono @Crash--