Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloning a note with images #4327

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Fix cloning a note with images #4327

merged 3 commits into from
Feb 13, 2024

Conversation

nono
Copy link
Member

@nono nono commented Feb 12, 2024

No description provided.

@nono nono requested a review from a team as a code owner February 12, 2024 12:39
taratatach
taratatach reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@taratatach taratatach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably check the available disk space before creating the copy (especially if we have images attached)

@nono nono force-pushed the fix-copy-note-with-images branch from bf54b0d to 0e88c80 Compare February 13, 2024 10:36
@nono nono merged commit 0c19202 into master Feb 13, 2024
4 checks passed
@nono nono deleted the fix-copy-note-with-images branch February 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taratatach taratatach taratatach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nono @taratatach