Manage the Nextcloud trash #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path for files/directories inside the NextCloud trashbin are NOT their parent path + their name, but also contains a suffix. So, we need to add the path to the response to allow the clients to make operations on them.
nono
commented
Jun 27, 2024
| "attributes": { | ||
| "type": "directory", | ||
| "name": "Old", | ||
| "path": "/trash/Old.d93571568", |
There was a problem hiding this comment.
@cballevre be careful, the path for things inside the trash is a bit weird and cannot be computed with just the parent and the name, so it was added to the response
There was a problem hiding this comment.
Interesting clarification. I saw that you added the path everywhere. In cozy-client, I add a second attribute named parentPath. It corresponds to the folder path. This is to make it easier to replay requests with sift.js (commit with some explanation). Wouldn't it make sense to add it to the back as well, so we wouldn't have to calculate anything on the front?
taratatach
reviewed
Jun 27, 2024
taratatach
reviewed
Jun 27, 2024
taratatach
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.