feat: Add legal notice URL to instance settings #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
feat/add-route-to-get-instance-legal-notice-url-from-cloudery
branch
3 times, most recently
from
b68385b to
a117c9c
Compare
Instead of duplicating the client building logic, we can get an instance of `instance.APIManagerClient` from the instance argument in the cloudery service methods.
When no cloudery is configured for the given instance context, cloudery service methods should not attempt to build a client and make an API call resulting in an error. They should return a noop result instead.
When an instance's context has an associated cloudery and the instance's partner on the cloudery has defined a legal notice, the URL to this notice will be present in the instance settings returned by `GET /settings/instance` calls.
taratatach
force-pushed
the
feat/add-route-to-get-instance-legal-notice-url-from-cloudery
branch
from
a117c9c to
0b8cc2d
Compare
nono
approved these changes
Nov 21, 2024
taratatach
deleted the
feat/add-route-to-get-instance-legal-notice-url-from-cloudery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instance's context has an associated cloudery and the
instance's partner on the cloudery has defined a legal notice, the URL
to this notice will be present in the instance settings returned by
GET /settings/instancecalls.