fix: Remove duplicated manager url config #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
fix/remove-duplicate-manager-url-attribute-in-context
branch
8 times, most recently
from
d4de327 to
ae0b118
Compare
The `WithManager` test helper is meant to help setup the test context for requests to a cloudery but it also depends on modifications made to the context config. We move these modifications to the helper itself to make it self-contained and avoid unexpected test results when using it without deep knowledge of its dependencies. We alos make sure to modify the config as little as possible and the changes once the test is completed.
We used to store the manager url in the context config in the `manager_url` attribute. We're now storing it as part of the `clouderies` config so we can remove the old attribute and its use. However, some clients still make use of the old context attribute so we're adding it back in the context API response for backwards compatibility.
taratatach
force-pushed
the
fix/remove-duplicate-manager-url-attribute-in-context
branch
from
ae0b118 to
d364aca
Compare
nono
approved these changes
Nov 27, 2024
taratatach
deleted the
fix/remove-duplicate-manager-url-attribute-in-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to store the manager url in the context config in the
manager_urlattribute.We're now storing it as part of the
clouderiesconfig so we canremove the old attribute and its use.
However, some clients still make use of the old context attribute so
we're adding it back in the context API response for backwards
compatibility.