Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP keep-alive for CouchDB connections #4497

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix HTTP keep-alive for CouchDB connections #4497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/couchdb/couchdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,11 @@ func makeRequest(db prefixer.Prefixer, doctype, method, path string, reqbody int
log.Error(err.Error())
return err
}
defer resp.Body.Close()
defer func() {
// Flush the body, so that the connection can be reused by keep-alive
_, _ = io.Copy(io.Discard, resp.Body)
_ = resp.Body.Close()
}()

if elapsed.Seconds() >= 10 {
log.Infof("slow request on %s %s (%s)", method, path, elapsed)
Expand All @@ -322,8 +326,6 @@ func makeRequest(db prefixer.Prefixer, doctype, method, path string, reqbody int
return err
}
if resbody == nil {
// Flush the body, so that the connection can be reused by keep-alive
_, _ = io.Copy(io.Discard, resp.Body)
return nil
}

Expand Down
Loading