tech: Cleanup example config from prod elements #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
reviewed
Dec 10, 2024
taratatach
force-pushed
the
tech/cleanup-example-config
branch
from
6b2a44c to
4bfab62
Compare
The example config should not contain elements such as URLs from our production environment as people might simply copy the file without changing some parts and end up making unnecessary requests to our servers.
taratatach
force-pushed
the
tech/cleanup-example-config
branch
from
4bfab62 to
148cfd9
Compare
nono
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example config should not contain elements such as URLs from our
production environment as people might simply copy the file without
changing some parts and end up making unnecessary requests to our
servers.