-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/navbar overhaul #2072
Merged
Merged
Feat/navbar overhaul #2072
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4b16466
feat: Update cozy-intent for flagship-UI
acezard e56f7f9
feat: Handle FlagshipUI for cozy-drive cases
acezard ea190b9
feat: Add Typescript support
acezard 542e55e
feat: Refactor setFlagshipUI feature
acezard c4c7a31
fix(deps): Upgrade few packages
acezard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { useEffect } from 'react' | ||
import { useWebviewIntent } from 'cozy-intent' | ||
import pickBy from 'lodash/pickBy' | ||
import identity from 'lodash/identity' | ||
import isEmpty from 'lodash/isEmpty' | ||
import isObject from 'lodash/isObject' | ||
|
||
export const useSetFlagshipUI = (onMount, onUnmount) => { | ||
const webviewIntent = useWebviewIntent() | ||
|
||
useEffect(() => { | ||
const parsedOnMount = isObject(onMount) && pickBy(onMount, identity) | ||
acezard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const parsedOnUnmount = isObject(onUnmount) && pickBy(onUnmount, identity) | ||
|
||
webviewIntent && | ||
!isEmpty(parsedOnMount) && | ||
webviewIntent.call('setFlagshipUI', parsedOnMount) | ||
|
||
return () => { | ||
webviewIntent && | ||
acezard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
!isEmpty(parsedOnUnmount) && | ||
webviewIntent.call('setFlagshipUI', parsedOnUnmount) | ||
} | ||
}, [webviewIntent]) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem que précédemment : pourquoi ce commit est nécessaire ici ? Est-ce qu'on peut ajouter de la description dans le commit message ?