feat: Add authentification dialog #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
zatteo
as code owners
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
from
c0e453b
to
b408137
Compare
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
2 times, most recently
from
b6f2021
to
5c8fe41
Compare
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
@JF-Cozy Would it make sense to create a folder to group all field types such as TextField and PasswordField? Or you'd see it in a different place |
|
On ne groupe aucun composant, à part quelques exceptions, je dirai donc non |
JF-Cozy
reviewed
Jul 3, 2023
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
from
5c8fe41
to
49f85a7
Compare
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
3 times, most recently
from
288172d
to
8c2da65
Compare
|
@JF-Cozy j'ai fait toutes les modifications qu'on avait discutées. Après discussion avec Joël, le fond de l'icône restera blanc pour le moment j'ai donc opté pour Est-ce qu'il y aurait moyen d'avoir une nouvelle review ? pls 🙏 |
JF-Cozy
reviewed
Jul 4, 2023
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
2 times, most recently
from
2a56764
to
742d808
Compare
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
from
742d808
to
722e17f
Compare
JF-Cozy
reviewed
Jul 5, 2023
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
from
722e17f
to
54a2fe9
Compare
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
from
54a2fe9
to
807a26b
Compare
JF-Cozy
approved these changes
Jul 5, 2023
cballevre
force-pushed
the
feat/add-authentification-dialog
branch
from
807a26b
to
cde78f9
Compare
|
🎉 This PR is included in version 88.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live demo