Skip to content

Commit

Permalink
fix(dev-scripts): Don't use alias when resolving blockly
Browse files Browse the repository at this point in the history
PR google#226 addedd a resolve.alias for blockly to webpack.config.js.
It is not entirely clear what the purpose of this was at the
time, but it has the effect of treating imports of submodules
(e.g. 'blockly/core') as if they were direct imports (e.g. of
'./node_modules/blockly/core.js'), causing webpack to ignore
the blockly package's package.json file.

This causes plugins to fail to build due to the introduction
of an exports stanza in that file (and other related changes)
in google/blockly#7822.
  • Loading branch information
cpcallen committed Feb 29, 2024
1 parent 3938745 commit 4be9f33
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions plugins/dev-scripts/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ module.exports = (env) => {
clean: true,
},
resolve: {
alias: {
'blockly': resolveApp('node_modules/blockly'),
},
extensions: ['.ts', '.js'].filter(
(ext) => isTypescript || !ext.includes('ts'),
),
Expand Down

0 comments on commit 4be9f33

Please sign in to comment.