Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests #59

Open
cpina opened this issue Jan 22, 2022 · 4 comments · May be fixed by #48 or #39
Open

Write tests #59

cpina opened this issue Jan 22, 2022 · 4 comments · May be fixed by #48 or #39
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cpina
Copy link
Owner

cpina commented Jan 22, 2022

(Maintainer here)

Before adding more features and merging PRs (unless they fix an error) I want to write tests for the github action (should have been done long time ago).

Testing the action is getting harder and harder as we add features and I really want to avoid regressions.

I might have some time towards end of February 2022 but if anyone wants to have a look at writing tests it might speed up PR and issues.

I haven't planed yet how to implement the tests. If someone wants to help it might be a good idea to discuss options here.

Thanks for using it and for your patience!

@KaviiSuri
Copy link

Hey, If this issue is still up for grabs, I'd like to help out!

@cpina
Copy link
Owner Author

cpina commented Jul 9, 2022

@KaviiSuri (and anyone else) : apologies for missing to reply you in February!

Yes, this is still for grab. I'm opened to proposals on how to test it (which parts to mock / fake, test the final result would be nice not only the git call, etc.).

@KaviiSuri
Copy link

@cpina No issues, I'll research a bit and come up with a few options!

@pwall2222
Copy link

In #102 I added unit testing that it might not be exacly what @cpina was thinking about. I implemented unit testing as End-To-End testing would require very complex test suite and a lot of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment