Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shellcheck to improve the code quality #57

Closed
wants to merge 3 commits into from
Closed

Use shellcheck to improve the code quality #57

wants to merge 3 commits into from

Conversation

guzhongren
Copy link

  • feature: shellcheck & github ci
  • fix: some issue in entrypoint.sh

@cpina
Copy link
Owner

cpina commented Jan 22, 2022

Thanks very much @guzhongren - I've had a quick look and looks good to me. Will try to merge it soon.

This is very inline with #59 (adding tests) so I'm very happy with it :-)

@guzhongren
Copy link
Author

I'm not very good at the shell, so writing tests may be is hard for me, but if I have knowledge about shell tests, I'm happy to contribute. Thanks for your invitation.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guzhongren @cpina