Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content/6_Advanced/Multiplicative.mdx #4429

Merged
merged 80 commits into from
May 6, 2024
Merged

Update content/6_Advanced/Multiplicative.mdx #4429

merged 80 commits into from
May 6, 2024

Conversation

tqmsh
Copy link
Contributor

@tqmsh tqmsh commented Apr 8, 2024

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@tqmsh tqmsh requested a review from dongliuu as a code owner April 8, 2024 01:01
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright let's get started

content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bqi343 if you could review this module for clarity/correctness, that would be great 🙏

content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Multiplicative.mdx Outdated Show resolved Hide resolved
bqi343
bqi343 previously requested changes Apr 29, 2024
content/6_Advanced/Multiplicative.mdx Show resolved Hide resolved
@bqi343
Copy link
Member

bqi343 commented Apr 29, 2024

I didn't review the explanations so there are probably more issues. @dongliu0426 can you? or just merge without reviewing them, it's probably fine

@dongliuu dongliuu enabled auto-merge May 6, 2024 00:38
@ryanchou-dev ryanchou-dev dismissed bqi343’s stale review May 6, 2024 13:46

dong reviewed + changes addressed

Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll sansify when i have the time

@dongliuu dongliuu merged commit 6a20da7 into cpinitiative:master May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants