Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bounties] Critical Module Ravamp #4461

Merged
merged 55 commits into from
May 20, 2024
Merged

[Bounties] Critical Module Ravamp #4461

merged 55 commits into from
May 20, 2024

Conversation

brebenelmihnea
Copy link
Contributor

@brebenelmihnea brebenelmihnea commented May 3, 2024 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@brebenelmihnea brebenelmihnea requested a review from dongliuu as a code owner May 3, 2024 13:07
@brebenelmihnea
Copy link
Contributor Author

I'll add the proofs in other PR.

@brebenelmihnea
Copy link
Contributor Author

The code doesn't get AC without standard C I/O

@brebenelmihnea
Copy link
Contributor Author

brebenelmihnea commented May 17, 2024 •
edited
Loading

image
https://codeforces.com/contest/982/submission/261074232

ryanchou-dev
ryanchou-dev reviewed May 18, 2024
View reviewed changes
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great so far! just some minor nitpicks

content/6_Advanced/Critical.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Critical.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Critical.mdx Outdated Show resolved Hide resolved
@brebenelmihnea
Copy link
Contributor Author

@SansPapyrus683 finally merge ?

@brebenelmihnea brebenelmihnea requested review from SansPapyrus683 and removed request for SansPapyrus683 May 19, 2024 06:15
SansPapyrus683
SansPapyrus683 approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. check my edited explanation to see if it still makes sense
  2. fill in the ? i put where the time complexity should be

@SansPapyrus683
Copy link
Contributor

https://codeforces.com/contest/982/submission/261698419
also no need for proof of ac

@SansPapyrus683 SansPapyrus683 merged commit 9cd6023 into cpinitiative:master May 20, 2024
3 checks passed
@brebenelmihnea brebenelmihnea deleted the Critical branch May 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@dongliuu dongliuu Awaiting requested review from dongliuu dongliuu is a code owner

@ryanchou-dev ryanchou-dev Awaiting requested review from ryanchou-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brebenelmihnea @SansPapyrus683 @ryanchou-dev