Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOS DP Module Revamp #5076

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

SOS DP Module Revamp #5076

wants to merge 50 commits into from

Conversation

Sosuke23
Copy link
Contributor

@Sosuke23 Sosuke23 commented Jan 23, 2025 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

closes #4994
closes #4995

Vowels
AC (C++): https://codeforces.com/contest/383/submission/303675477
AC (Python): https://codeforces.com/contest/383/submission/303676749

@Sosuke23 Sosuke23 requested a review from dongliuu as a code owner January 23, 2025 07:21
@TheGamingMousse
Copy link
Contributor

by chance is it possible for you to test the implementation somewhere?

@Sosuke23
Copy link
Contributor Author

by chance is it possible for you to test the implementation somewhere?

Sorry but I don't have any proficiency in this particular topic.
I would appreciate if you would like to contribute to it.

@Sosuke23
Copy link
Contributor Author

On second thought give me some days I will se what I can do

bqi343
bqi343 reviewed Feb 8, 2025
View reviewed changes
content/5_Plat/DP_SOS.mdx Outdated Show resolved Hide resolved
bqi343
bqi343 reviewed Feb 8, 2025
View reviewed changes
content/5_Plat/DP_SOS.mdx
<CPPSection>

```cpp
for (int i = 0; i < (1 << n); i++) { sos[i] = a[i]; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not sos = a?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the basics looks good

bqi343
bqi343 reviewed Feb 8, 2025
View reviewed changes
content/5_Plat/DP_SOS.mdx Outdated Show resolved Hide resolved
bqi343
bqi343 reviewed Feb 8, 2025
View reviewed changes
content/5_Plat/DP_SOS.mdx Outdated Show resolved Hide resolved
@bqi343
Copy link
Member

bqi343 commented Feb 8, 2025

Looks good! Just added a bunch of minor comments.

@bqi343
Copy link
Member

bqi343 commented Feb 8, 2025

Should I move the focus problem above the n-dimensional explanation or leave it as it is?

It's good where it is.

Sosuke23 and others added 8 commits February 9, 2025 08:03
bqi343
bqi343 reviewed Feb 9, 2025
View reviewed changes
content/5_Plat/DP_SOS.mdx Outdated Show resolved Hide resolved
bqi343
bqi343 reviewed Feb 9, 2025
View reviewed changes
content/5_Plat/DP_SOS.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqi343 bqi343 bqi343 left review comments

@dongliuu dongliuu Awaiting requested review from dongliuu dongliuu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Sosuke23 @TheGamingMousse @bqi343