Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draft for build systems #93

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Add draft for build systems #93

merged 8 commits into from
Nov 4, 2024

Conversation

diehlpk
Copy link
Contributor

@diehlpk diehlpk commented May 17, 2024 •
edited
Loading

First draft produced by during American group meeting.

#12

diehlpk and others added 2 commits May 17, 2024 16:34
@diehlpk
Copy link
Contributor Author

diehlpk commented Jul 26, 2024

@vulder @jcvw The US group discussed this pull request in today's meeting and we would move it to tentatively ready. We would appreciate to get feedback from the European group.

@vulder vulder requested review from vulder and jcvw October 2, 2024 07:00
vulder
vulder requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks for giving this topic a first version.

sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Show resolved Hide resolved
sources/modules/compilation-model/buildsystems.md Outdated Show resolved Hide resolved
@vulder vulder added Tentatively ready Ready for a final review in SG20 SG20-reviewed Reviewed by a SG20 meeting, ready to be merged after comment resolution. labels Oct 18, 2024
@ronchaine
Copy link

Should there be a mention of handling of (unit) testing, probably in advanced, as that is often handled by the build system? Not sure if it is better to mention here or not.

@diehlpk
Copy link
Contributor Author

diehlpk commented Oct 20, 2024

Should there be a mention of handling of (unit) testing, probably in advanced, as that is often handled by the build system? Not sure if it is better to mention here or not.

We could make a note that some build systems have this feature.

@diehlpk
Update buildsystems.md
f50e498 
Mention unit testing
@diehlpk
Copy link
Contributor Author

diehlpk commented Oct 21, 2024

Should there be a mention of handling of (unit) testing, probably in advanced, as that is often handled by the build system? Not sure if it is better to mention here or not.

We could make a note that some build systems have this feature.

I added it to the latest commit

diehlpk and others added 3 commits October 20, 2024 21:06
@diehlpk
Update buildsystems.md
430c317 
Move building a lib and link it to a C++ executable to the main level
@diehlpk
Update buildsystems.md
ee55d0e
make it more precise
cbbfbe2
@diehlpk
Copy link
Contributor Author

diehlpk commented Oct 31, 2024

@vulder and @ronchaine I think I addressed all your comments.

Please have a look again.

@VictorEijkhout
Copy link
Contributor

VictorEijkhout commented Oct 31, 2024 via email

@ronchaine
Copy link

LGTM

@diehlpk
Copy link
Contributor Author

diehlpk commented Nov 4, 2024

Co-authored-by: Victor Eijkhout [email protected]
Co-authored-by: Daniel Hanson [email protected]

@vulder vulder self-requested a review November 4, 2024 19:43
@vulder vulder merged commit 3a305f5 into cplusplus:master Nov 4, 2024
4 checks passed
vulder pushed a commit that referenced this pull request Nov 4, 2024
@diehlpk @vulder
Adds initial draft for build systems (#93)
9758a39 
---------
Co-authored-by: Victor Eijkhout <[email protected]>
Co-authored-by: Daniel Hanson <[email protected]>
Co-authored-by: Patrick Diehl <[email protected]>
vulder pushed a commit that referenced this pull request Nov 4, 2024
@diehlpk @VictorEijkhout @vulder
Adds initial draft for build systems (#93)
ea5bb4a 
Co-authored-by: Victor Eijkhout <[email protected]>
Co-authored-by: Daniel Hanson <[email protected]>
Co-authored-by: Patrick Diehl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronchaine ronchaine ronchaine left review comments

@vulder vulder vulder approved these changes

@jcvw jcvw Awaiting requested review from jcvw

Assignees
No one assigned
Labels
SG20-reviewed Reviewed by a SG20 meeting, ready to be merged after comment resolution. Tentatively ready Ready for a final review in SG20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diehlpk @ronchaine @VictorEijkhout @vulder