Update version checks to avoid cmake issue #26243 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
reviewed
Nov 25, 2024
Avus-c
force-pushed
the
fix/update_cmake_version_check
branch
from
e009136
to
3d2b1dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603
Related to #570
This PR updates the CMake version check from
3.28.0to3.30.0due to a known bug affecting versions up to3.30.2. The issue has been resolved in CMake3.30.3(see CMake issue #26243).Users may still encounter the issue described in #603 when using CMake versions
3.30.0to3.30.2.Instead of using the non-deprecated function starting from
3.30.0, we could set it to3.30.3, where the bug is fixed.However, it will then trigger deprecation warnings.
Basically if someone uses CPM >=0.40.1, and cmake 3.30.0 - 3.30.2, they run into either deprecation errors or a cmake bug, no matter what we do.