put codebase into dog namespace #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karnkaul
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Any reason Services is not in namespace dog?
There was a problem hiding this comment.
I think I just missed it. Also, should test_services, test, and build_version be in namespace dog as well? The last is currently in namespace dog_tales
There was a problem hiding this comment.
Yup that's correct, all the code we add to this project should be in the same namespace (or a nested one).
There was a problem hiding this comment.
Remember to remove dog:: qualifications after you add Services to the namespace. 😄
|
Taking over stale PR. |
karnkaul
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
dognamespace