Add support to use cmake package configuration file from boost #154

Bjoe · 2020-02-13T08:22:16Z

I've followed this guide
step by step carefully. Yes
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
- https://ci.appveyor.com/project/Bjoe/hunter-t1t06/builds/30740305
- https://travis-ci.org/Bjoe/hunter/builds/649294215

It is needed, even when you set CONFIG in find_package! See BoostConfig line 51 in hunter. The original FindBoost from cmake add for example in iostream regex as required dependency but this is an optional dependency ....

Bjoe · 2020-02-13T08:56:58Z

This PR introduced the possibility to use the cmake config module provided from the boost project.
It is optional and can be enabled via hunter_config. Add as CMAKE_ARGS USE_CONFIG_FROM_BOOST=ON

That has the advantage that the "user" does not need to know which dependency for example boost::log needs. See the difference in the diff https://github.com/cpp-pm/hunter/pull/154/files#diff-20118a896da0e1fbefa637e8075cb6fa

It will also solve a potential problem that the BoostConfig from hunter is using FindBoost see #139

…onfig

Bjoe · 2020-02-13T09:01:21Z

Btw. this PR needs the PR from #140

daminetreg · 2020-02-13T09:12:28Z

That has the advantage that the "user" does not need to know which dependency for example boost::log needs. See the difference in the diff https://github.com/cpp-pm/hunter/pull/154/files#diff-20118a896da0e1fbefa637e8075cb6fa

Note that this isn't fully true, you just need a cmake version that knows about the Boost version and then it automatically adds the knowledge of what you need to link transitively. It doesn't know when cmake is older than boost.

But clearly it's better to trust boost whenever everything works fine. The problem is mostly for me the static vs shared strategy that we should get changed.

Bjoe · 2020-02-13T09:17:36Z

@daminetreg Yep I know, but hunter introduced its own FindBoost.cmake and it is not well maintained ...

@daminetreg Did you know why in hunter is a FindBoost.cmake?

Bjoe · 2020-02-13T09:18:29Z

@daminetreg Maybe you can update this FindBoost.cmake in hunter in your PR #140 ?

daminetreg · 2020-02-14T10:34:00Z

@daminetreg Yep I know, but hunter introduced its own FindBoost.cmake and it is not well maintained ...

Oh 😨 Thanks for noticing, I didn't remember that.

@daminetreg Did you know why in hunter is a FindBoost.cmake?

I think he might have updated based on the version of Boost @ruslo integrated but I'm unsure. I'll try to find the common ancestor in cmake repository in the times he added the "fixed" FindBoost to see what changes he operated.

@daminetreg Maybe you can update this FindBoost.cmake in hunter in your PR #140 ?

If I can I'll make a separate PR for this, because it's better to have what we have now, than to extend the scope infinitely of this PR.

rbsheth · 2020-02-15T16:48:33Z

@Bjoe #140 is merged, do you need to update this one?

Bjoe · 2020-02-16T13:05:35Z

@Bjoe #140 is merged, do you need to update this one?

@rbsheth Yep. I will do this .... give me some time

BenWhetton · 2020-02-17T16:29:43Z

Does anybody know hunter maintains a fork of FindBoost.cmake? It seems like something that should be understood before bolting on more complexity to work around it?

Bjoe · 2020-02-19T07:51:21Z

@BenWhetton FindBoost.cmake in hunter was introduced four years ago ... I'm not sure what you mean with bolting on more complexity to work around it?

Again my idea is to use the BoostConfig from boost so that BoostConfig and FindBoost from hunter is not any more used (maybe remove it) ... in my opinion it is lesser complexity and lesser maintained stuff in hunter ...

Bjoe · 2020-02-19T08:13:07Z

Btw. since I merge latest master and introduced a USE_CONFIG_FROM_BOOST 1f1e729 ... it unfortunately not working very well.
If you want to have a successful test with BoostConfig from boost, then use this commit 14eb85c ...

I'm working on a proper solution to have both approaches in hunter ...

Bjoe · 2020-02-19T08:56:46Z

Sorry, this problem that I mentioned above was only a local issue. 1f1e729 is absolutely working correctly.

See also Travis/AppVeyor test builds:

Please test/give it a try and give your opinion

This is the hunter "version config" to test:

HunterGate(
    URL "https://github.com/Bjoe/hunter/archive/1f1e7295e026b5b6bdf6122a98d36d521fff1dbb.zip"
    SHA1 "69417c1d41f39be07465dc57e115ef97b2c648f2"
    LOCAL
)

Add in the [YOUR_PROJECT_SRC_DIR]/cmake/Hunter/config.cmake:

hunter_config(Boost VERSION 1.72.0-p0 CMAKE_ARGS USE_CONFIG_FROM_BOOST=ON)

As additional information:
I occupy all the tests in hunter to verify if my solution is working. This should not be merged because it should also test the old behaviour. Should I add some "new tests" or "take only some tests"?

rbsheth · 2020-02-21T16:38:33Z

Should I add some "new tests" or "take only some tests"?

What do you mean by this? If you want to test both the old and new behavior, you can add some new tests for this flag.

BenWhetton · 2020-02-24T14:59:16Z

@BenWhetton FindBoost.cmake in hunter was introduced four years ago ... I'm not sure what you mean with bolting on more complexity to work around it?

Again my idea is to use the BoostConfig from boost so that BoostConfig and FindBoost from hunter is not any more used (maybe remove it) ... in my opinion it is lesser complexity and lesser maintained stuff in hunter ...

I believe this solution will not work for previous versions of Boost where there is no CMake support so it is not a full solution to #141.

Bjoe · 2020-02-25T04:46:36Z

@BenWhetton Yep absolutely right, that's why I added a Boost version check ... for example

hunter/cmake/projects/Boost/schemes/url_sha1_boost.cmake.in

Line 168 in b2bd8ae

if(NOT USE_CONFIG_FROM_BOOST OR HUNTER_Boost_VERSION VERSION_LESS 1.72.0)

and

hunter/cmake/projects/Boost/hunter.cmake

Line 428 in b2bd8ae

if(NOT HUNTER_Boost_VERSION VERSION_LESS 1.72.0)

As I said ... maybe we can remove it .... but I think it is not yet possible to remove it because it has to be backward compatible ....

Sometimes I think, maybe it is better to create a new "Boost" package with boost config support? It is maybe lesser to "maintain"/ better to understand? But I don't know if the "community"/user will understands this?

Bjoe · 2020-02-25T20:20:28Z

@rbsheth Ok, I added some new tests: Boost-useBoostConfig, Boost-filesystem-useBoostConfig, Boost-iostream-useBoostConfig, Boost-chrono-useBoostConfig and Boost-log-useBoostConfig

Here is the links to the Travis/AppVeyor with status "All passed":

I think I should add a comment in the Boost.rst .... I will do this next days...

Bjoe · 2020-03-04T20:09:27Z

Ok, I added a hint about USE_CONFIG_FROM_BOOST in the boost doc (Boost.rst)

So I'm done ...
Let's review/discuss/test :-)

Discussable is maybe that approach in hunter.cmake line 428 - 448 to set the package configuration options for the boost package configuration file.

rbsheth · 2020-03-06T14:32:34Z

@Bjoe Do you think this is ready for merge?

Bjoe · 2020-03-10T09:00:14Z

All test`s are green:

With enabled USE_CONFIG_FROM_BOOST

Without enabled USE_CONFIG_FROM_BOOST

So from my side it looks fine.

It would be great if someone else can test this also ... or you wait until I test that in my company where we build a project for iOS, Android, linux, Windows and macOS.....

Bjoe added 28 commits January 22, 2020 10:10

Fix path in cmake config modul of boost

24cd58a

Remove boost config module in hunter

2ee27c9

Increment package id

427825a

Add Boost_USE_STATIC_LIBS in examples....

c98a627

Fix boost iostream example...

3965e72

Fix example, add Boost_USE_STATIC_LIBS

9aff1b9

Add workaround in example to fix test on travis

8311a67

If an older boost version is used... use BoostConfig from hunter

289bf11

Try to fix windows test builds

9e58dbc

Add FindBoost.cmake again,

aa0551c

It is needed, even when you set CONFIG in find_package! See BoostConfig line 51 in hunter. The original FindBoost from cmake add for example in iostream regex as required dependency but this is an optional dependency ....

Fix iOS build, set install target

2a4d70c

Split build and install target on iOS build

2f22dbe

Enable boost debug

37bcbd5

Use Boost::boost because example is build also with older versions

33cb8cd

Comment out fix, needs impovement

c14fc47

Fix mingw/boost 1.64 test build

076b510

Fix vs builds

e2978c8

Cleanup boost thread test build

c1752ce

Fix boost system test on windows

3588138

Improve boost log test

730d526

Set Boost_USE_STATIC_LIBS when not HUNTER_BUILD_SHARED_LIBS

65d3182

Get cmake args for Boost

6e3f71e

Fix use boost static libs in windows

957ecab

Introduced USE_CONFIG_FROM_BOOST

92ada88

use boost config if not boost version less then 1.72

7b0d370

If boost version should be 1.72 or greater

54d61b0

if not BOOST_BUILD_DYNAMIC_VSRUNTIME use boost static runtime

42ecac9

Fix some review findings

30882c2

Merge remote-tracking branch 'origin/master' into pr.boost.use-boostc…

d668ebd

…onfig

This was referenced Feb 13, 2020

Boost 1.72.0-p0 fails on Boost::boost #133

Closed

Boost library link dependencies are incorrect #141

Open

Increase PACKAGE_INTERNAL_DEPS_ID

14eb85c

Bjoe added 2 commits February 16, 2020 14:26

Merge branch 'master' into pr.boost.use-boostconfig

86a74e0

Create boost config from boost if USE_CONFIG_FROM_BOOST is set

1f1e729

Use only some examples to use config from boost

b2bd8ae

Fix boost log example

8ff9b71

Add USE_CONFIG_FROM_BOOST hint in boost doc

4187249

Bjoe changed the title ~~Add support to use cmake config modul from boost~~ Add support to use cmake package configuration file from boost Mar 5, 2020

rbsheth approved these changes Mar 13, 2020

View reviewed changes

rbsheth merged commit ef5bfcd into cpp-pm:master Mar 13, 2020

rbsheth mentioned this pull request Mar 1, 2021

Static boost libraries cannot be found after compilation in ppc64le architecture #351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to use cmake package configuration file from boost #154

Add support to use cmake package configuration file from boost #154

Bjoe commented Feb 13, 2020

Bjoe commented Feb 13, 2020

Bjoe commented Feb 13, 2020

daminetreg commented Feb 13, 2020

Bjoe commented Feb 13, 2020

Bjoe commented Feb 13, 2020

daminetreg commented Feb 14, 2020

rbsheth commented Feb 15, 2020

Bjoe commented Feb 16, 2020

BenWhetton commented Feb 17, 2020

Bjoe commented Feb 19, 2020 •

edited

Loading

Bjoe commented Feb 19, 2020 •

edited

Loading

Bjoe commented Feb 19, 2020 •

edited

Loading

rbsheth commented Feb 21, 2020

BenWhetton commented Feb 24, 2020

Bjoe commented Feb 25, 2020

Bjoe commented Feb 25, 2020

Bjoe commented Mar 4, 2020

rbsheth commented Mar 6, 2020

Bjoe commented Mar 10, 2020

Add support to use cmake package configuration file from boost #154

Add support to use cmake package configuration file from boost #154

Conversation

Bjoe commented Feb 13, 2020

Bjoe commented Feb 13, 2020

Bjoe commented Feb 13, 2020

daminetreg commented Feb 13, 2020

Bjoe commented Feb 13, 2020

Bjoe commented Feb 13, 2020

daminetreg commented Feb 14, 2020

rbsheth commented Feb 15, 2020

Bjoe commented Feb 16, 2020

BenWhetton commented Feb 17, 2020

Bjoe commented Feb 19, 2020 • edited Loading

Bjoe commented Feb 19, 2020 • edited Loading

Bjoe commented Feb 19, 2020 • edited Loading

rbsheth commented Feb 21, 2020

BenWhetton commented Feb 24, 2020

Bjoe commented Feb 25, 2020

Bjoe commented Feb 25, 2020

Bjoe commented Mar 4, 2020

rbsheth commented Mar 6, 2020

Bjoe commented Mar 10, 2020

Bjoe commented Feb 19, 2020 •

edited

Loading

Bjoe commented Feb 19, 2020 •

edited

Loading

Bjoe commented Feb 19, 2020 •

edited

Loading