Skip to content

Update Boost to v1.74.0 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Jan 15, 2021
Merged

Update Boost to v1.74.0 #316

merged 44 commits into from
Jan 15, 2021

Conversation

Bjoe
Copy link

@Bjoe Bjoe commented Dec 5, 2020

  • I've followed this guide
    step by step carefully. Yes

@Bjoe Bjoe changed the title Pr.boost Update Boost to 1.74.0 Dec 5, 2020
@Bjoe Bjoe changed the title Update Boost to 1.74.0 Update Boost to v1.74.0 Dec 5, 2020
@Bjoe
Copy link
Author

Bjoe commented Dec 6, 2020

@rbsheth I fixed some issue to build boost but somehow the github action didn't trigger the ci builds again ... I assume that the ci builds again when I finishing this PR .... not sure

@Bjoe Bjoe marked this pull request as ready for review December 6, 2020 17:09
@Bjoe
Copy link
Author

Bjoe commented Dec 6, 2020

I''m struggling with the CI builds ... how can I restarts the Ci builds? At least the failing jobs? Also on my fork it doesn't work. Github actions are "on". Or has this something to do that have more then 256 jobs per workflow? I added for the other Boost examples a job....

@rbsheth
Copy link
Member

rbsheth commented Dec 6, 2020

I''m struggling with the CI builds ... how can I restarts the Ci builds? At least the failing jobs? Also on my fork it doesn't work. Github actions are "on". Or has this something to do that have more then 256 jobs per workflow? I added for the other Boost examples a job....

Probably - try just the basic builds first. We can split project matrices to different folders if needed.

@Bjoe
Copy link
Author

Bjoe commented Dec 7, 2020

@rbsheth Ok I reduce the toolchain matrix. Now it builds again :-), but let try to do some last fixes. I will give you a hint when I'm ready

@Bjoe Bjoe changed the title Update Boost to v1.74.0 WIP: Update Boost to v1.74.0 Dec 7, 2020
@rbsheth
Copy link
Member

rbsheth commented Dec 7, 2020

Sounds good!

@rbsheth
Copy link
Member

rbsheth commented Jan 4, 2021

@Bjoe Happy new year! How is this going?

This reverts commit eb2aff8.

# Conflicts:
#	cmake/projects/Boost/ci/matrix.json
#	cmake/projects/Boost/hunter.cmake
#	examples/Boost-chrono/CMakeLists.txt
#	examples/Boost-contract/CMakeLists.txt
#	examples/Boost-custom-args/CMakeLists.txt
#	examples/Boost-fiber/CMakeLists.txt
#	examples/Boost-filesystem-shared/CMakeLists.txt
#	examples/Boost-filesystem/CMakeLists.txt
#	examples/Boost-iostreams/CMakeLists.txt
#	examples/Boost-log-shared/CMakeLists.txt
#	examples/Boost-log/CMakeLists.txt
#	examples/Boost-math/CMakeLists.txt
#	examples/Boost-program-options/CMakeLists.txt
#	examples/Boost-python/CMakeLists.txt
#	examples/Boost-random/CMakeLists.txt
#	examples/Boost-serialization/CMakeLists.txt
#	examples/Boost-stacktrace/CMakeLists.txt
#	examples/Boost-system/CMakeLists.txt
#	examples/Boost-test/CMakeLists.txt
#	examples/Boost-thread/CMakeLists.txt
#	examples/Boost-uuid/CMakeLists.txt
#	examples/Boost/CMakeLists.txt
@Bjoe
Copy link
Author

Bjoe commented Jan 11, 2021

@Bjoe Happy new year! How is this going?

Happy new year @rbsheth .... sorry, I try to use the "Boost-Config" from boost project as default like FindBoost in cmake did and to resolve this issue that the "FindBoost" in hunter is outdated. (See discussion #141) Unfortunately the boost project is using IN_LIST operator and it needs cmake version 3.3 at least. I try to force or to verify via hunter to set this policy or disable to use boost config. It works but unfortunately, there is a depended project BoostProcess and it set as cmake minimum version 3.0 and I didn't find yet any solution how I can verify in cmake which "minimum version" are set :-(.

So I revert commit eb2aff8 to have still the "old" solution with the option to set explicitly USE_CONFIG_FROM_BOOST ... what I really recommended !

Also the windows vs-15 builds are broken because of a "space" in a path! I try to solve but it was yet impossible for me. I need a windows machine for this. Maybe I found time to setup one Window machine in a virtualbox ... but this is also a bigger task ....

So let me revert a little bit, cleanup and then merge ....

@Bjoe
Copy link
Author

Bjoe commented Jan 12, 2021

Ok when the build is done, this can be merged! Please squash and merge my commits!

@Bjoe Bjoe changed the title WIP: Update Boost to v1.74.0 Update Boost to v1.74.0 Jan 12, 2021
Copy link
Member

@rbsheth rbsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@rbsheth rbsheth merged commit 83dd9a3 into cpp-pm:master Jan 15, 2021
@rbsheth
Copy link
Member

rbsheth commented Jan 15, 2021

tstack pushed a commit to tstack/hunter that referenced this pull request Jan 28, 2021
* Initial commit

* Add boost container

* Remove seperate boost container project

* decrement project version

* Remove separate boost container documentation

* Fix example

* Update 'boost' to 1.74.0

* Update boost components

* Add ci matrix to build other boost examples

* Fix some minor json issue

* Fix test builds. Minimum cmake version is 3.3

* Update boost doc

* Fix issue in doc

* Fix boost-user.jam toolset file to build boost

* push ci builds

* Remove some example test in CI matrix

* Try to fix boost build for windows

* Try to fix boost build on windows

* Fix b2 call in msys build

* Try to use new boost version for mingw

* Adding bat output

* Try to show bat output

* Try to build boost for windows

* Use boost config from boost as default

* Reduce ci jobs

* Verfiy if cmake version is equal or greater then 3.3 to use boost config from boost

* Fix older boost builds

* REVERT ME! only for testing for windows build

* REVERT ME!! only for windows build testing

* Fix findings

* try to fix MSVC settings

* Add quotes

* REVERT ME!! Only for windows build

* Add comment

* Revert "REVERT ME!! Only for windows build"

This reverts commit f0a8e99.

* Revert "REVERT ME!! only for windows build testing"

This reverts commit 9905988.

* Revert "REVERT ME! only for testing for windows build"

This reverts commit 060b9fc.

* Fix boost example to test older boost version

* Revert "Use boost config from boost as default"

This reverts commit eb2aff8.

# Conflicts:
#	cmake/projects/Boost/ci/matrix.json
#	cmake/projects/Boost/hunter.cmake
#	examples/Boost-chrono/CMakeLists.txt
#	examples/Boost-contract/CMakeLists.txt
#	examples/Boost-custom-args/CMakeLists.txt
#	examples/Boost-fiber/CMakeLists.txt
#	examples/Boost-filesystem-shared/CMakeLists.txt
#	examples/Boost-filesystem/CMakeLists.txt
#	examples/Boost-iostreams/CMakeLists.txt
#	examples/Boost-log-shared/CMakeLists.txt
#	examples/Boost-log/CMakeLists.txt
#	examples/Boost-math/CMakeLists.txt
#	examples/Boost-program-options/CMakeLists.txt
#	examples/Boost-python/CMakeLists.txt
#	examples/Boost-random/CMakeLists.txt
#	examples/Boost-serialization/CMakeLists.txt
#	examples/Boost-stacktrace/CMakeLists.txt
#	examples/Boost-system/CMakeLists.txt
#	examples/Boost-test/CMakeLists.txt
#	examples/Boost-thread/CMakeLists.txt
#	examples/Boost-uuid/CMakeLists.txt
#	examples/Boost/CMakeLists.txt

* Move boost to hunter boost repo

* FOR TESTING 1.74.0-p0 (REVERT ME)

* Revert "FOR TESTING 1.74.0-p0 (REVERT ME)"

This reverts commit d9c3c5c.
@olliwang
Copy link

olliwang commented Jan 29, 2021

Any idea why this PR breaks iOS build? Hunter v0.23.289 works just fine but not since v0.23.290 anymore. It seems the sys root is wrong. I saw error logs like this:

In file included from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk/usr/include/unistd.h:72:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk/usr/include/sys/unistd.h:180:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk/usr/include/sys/_types/_size_t.h:31:9: error: unknown type name '__darwin_size_t'
typedef __darwin_size_t        size_t;

I think it was building for iOS simulator but using iPhoneOS SDK.

@Bjoe
Copy link
Author

Bjoe commented Feb 1, 2021

Any idea why this PR breaks iOS build? Hunter v0.23.289 works just fine but not since v0.23.290 anymore. It seems the sys root is wrong. I saw error logs like this:

In file included from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk/usr/include/unistd.h:72:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk/usr/include/sys/unistd.h:180:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk/usr/include/sys/_types/_size_t.h:31:9: error: unknown type name '__darwin_size_t'
typedef __darwin_size_t        size_t;

I think it was building for iOS simulator but using iPhoneOS SDK.

Which boost version you are using? Can I have also the cmake output with hunter debug enabled? And please create an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants