-
Notifications
You must be signed in to change notification settings - Fork 187
Update Boost to v1.74.0 #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rbsheth I fixed some issue to build boost but somehow the github action didn't trigger the ci builds again ... I assume that the ci builds again when I finishing this PR .... not sure |
I''m struggling with the CI builds ... how can I restarts the Ci builds? At least the failing jobs? Also on my fork it doesn't work. Github actions are "on". Or has this something to do that have more then 256 jobs per workflow? I added for the other Boost examples a job.... |
Probably - try just the basic builds first. We can split project matrices to different folders if needed. |
@rbsheth Ok I reduce the toolchain matrix. Now it builds again :-), but let try to do some last fixes. I will give you a hint when I'm ready |
Sounds good! |
@Bjoe Happy new year! How is this going? |
This reverts commit eb2aff8. # Conflicts: # cmake/projects/Boost/ci/matrix.json # cmake/projects/Boost/hunter.cmake # examples/Boost-chrono/CMakeLists.txt # examples/Boost-contract/CMakeLists.txt # examples/Boost-custom-args/CMakeLists.txt # examples/Boost-fiber/CMakeLists.txt # examples/Boost-filesystem-shared/CMakeLists.txt # examples/Boost-filesystem/CMakeLists.txt # examples/Boost-iostreams/CMakeLists.txt # examples/Boost-log-shared/CMakeLists.txt # examples/Boost-log/CMakeLists.txt # examples/Boost-math/CMakeLists.txt # examples/Boost-program-options/CMakeLists.txt # examples/Boost-python/CMakeLists.txt # examples/Boost-random/CMakeLists.txt # examples/Boost-serialization/CMakeLists.txt # examples/Boost-stacktrace/CMakeLists.txt # examples/Boost-system/CMakeLists.txt # examples/Boost-test/CMakeLists.txt # examples/Boost-thread/CMakeLists.txt # examples/Boost-uuid/CMakeLists.txt # examples/Boost/CMakeLists.txt
Happy new year @rbsheth .... sorry, I try to use the "Boost-Config" from boost project as default like FindBoost in cmake did and to resolve this issue that the "FindBoost" in hunter is outdated. (See discussion #141) Unfortunately the boost project is using So I revert commit eb2aff8 to have still the "old" solution with the option to set explicitly Also the windows vs-15 builds are broken because of a "space" in a path! I try to solve but it was yet impossible for me. I need a windows machine for this. Maybe I found time to setup one Window machine in a virtualbox ... but this is also a bigger task .... So let me revert a little bit, cleanup and then merge .... |
# Conflicts: # cmake/configs/default.cmake # cmake/projects/Boost/hunter.cmake
This reverts commit d9c3c5c.
Ok when the build is done, this can be merged! Please squash and merge my commits! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
* Initial commit * Add boost container * Remove seperate boost container project * decrement project version * Remove separate boost container documentation * Fix example * Update 'boost' to 1.74.0 * Update boost components * Add ci matrix to build other boost examples * Fix some minor json issue * Fix test builds. Minimum cmake version is 3.3 * Update boost doc * Fix issue in doc * Fix boost-user.jam toolset file to build boost * push ci builds * Remove some example test in CI matrix * Try to fix boost build for windows * Try to fix boost build on windows * Fix b2 call in msys build * Try to use new boost version for mingw * Adding bat output * Try to show bat output * Try to build boost for windows * Use boost config from boost as default * Reduce ci jobs * Verfiy if cmake version is equal or greater then 3.3 to use boost config from boost * Fix older boost builds * REVERT ME! only for testing for windows build * REVERT ME!! only for windows build testing * Fix findings * try to fix MSVC settings * Add quotes * REVERT ME!! Only for windows build * Add comment * Revert "REVERT ME!! Only for windows build" This reverts commit f0a8e99. * Revert "REVERT ME!! only for windows build testing" This reverts commit 9905988. * Revert "REVERT ME! only for testing for windows build" This reverts commit 060b9fc. * Fix boost example to test older boost version * Revert "Use boost config from boost as default" This reverts commit eb2aff8. # Conflicts: # cmake/projects/Boost/ci/matrix.json # cmake/projects/Boost/hunter.cmake # examples/Boost-chrono/CMakeLists.txt # examples/Boost-contract/CMakeLists.txt # examples/Boost-custom-args/CMakeLists.txt # examples/Boost-fiber/CMakeLists.txt # examples/Boost-filesystem-shared/CMakeLists.txt # examples/Boost-filesystem/CMakeLists.txt # examples/Boost-iostreams/CMakeLists.txt # examples/Boost-log-shared/CMakeLists.txt # examples/Boost-log/CMakeLists.txt # examples/Boost-math/CMakeLists.txt # examples/Boost-program-options/CMakeLists.txt # examples/Boost-python/CMakeLists.txt # examples/Boost-random/CMakeLists.txt # examples/Boost-serialization/CMakeLists.txt # examples/Boost-stacktrace/CMakeLists.txt # examples/Boost-system/CMakeLists.txt # examples/Boost-test/CMakeLists.txt # examples/Boost-thread/CMakeLists.txt # examples/Boost-uuid/CMakeLists.txt # examples/Boost/CMakeLists.txt * Move boost to hunter boost repo * FOR TESTING 1.74.0-p0 (REVERT ME) * Revert "FOR TESTING 1.74.0-p0 (REVERT ME)" This reverts commit d9c3c5c.
Any idea why this PR breaks iOS build? Hunter v0.23.289 works just fine but not since v0.23.290 anymore. It seems the sys root is wrong. I saw error logs like this:
I think it was building for iOS simulator but using iPhoneOS SDK. |
Which boost version you are using? Can I have also the cmake output with hunter debug enabled? And please create an issue. |
step by step carefully. Yes