Skip to content

Update minimum CMake to v3.10 #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update minimum CMake to v3.10 #769

wants to merge 3 commits into from

Conversation

hjmallon
Copy link

  • I've checked this Git style guide. [Yes]
  • I've checked this CMake style guide. [Yes]
  • My change will work with CMake 3.5 (minimum requirement for Hunter). [No]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]

Also needs a gate update after cpp-pm/gate#18

@hjmallon hjmallon mentioned this pull request Dec 17, 2024
Open
@turuslan turuslan mentioned this pull request Mar 24, 2025
Merged
@Waarbubble
Copy link

Is there an ETA on when this can be approved, or where in the progress this is?

@chfast chfast mentioned this pull request Apr 7, 2025
Open
NeroBurner
NeroBurner requested changes Apr 10, 2025
View reviewed changes
Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor documentation update and then we're good to go!

Thanks for the PR

@NeroBurner
Copy link

Just merged the Gate PR cpp-pm/gate#18
And created a release: https://github.com/cpp-pm/gate/releases/tag/v0.11.0

Could you update the gate submodule to that tag as well in this PR please

@hjmallon
Copy link
Author

I have updated the gate submodule and also found some more places in examples where the older version was set

@chfast
Copy link

chfast commented Apr 25, 2025

How are we doing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeroBurner NeroBurner NeroBurner requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hjmallon @Waarbubble @NeroBurner @chfast