Update parser tests to include comments about heap-allocation

cppalliance · Dec 24, 2023 · af01a36 · af01a36
1 parent 2d8f53d
commit af01a36
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/test/unit/parser.cpp b/test/unit/parser.cpp
@@ -496,6 +496,12 @@ struct parser_test
             if( ! BOOST_TEST(! ec.failed()) ||
                 ! BOOST_TEST(pr->got_header()))
                 return;
+
+            // we use a heap-allocated std::string object because internally,
+            // parsers store copies of the provided buffers (which have view
+            // semantics)
+            // placing the object on the heap ensures reliable
+            // use-after-free errors are produced under sanitized builds
             std::unique_ptr<std::string> ptmp(new std::string());
             auto &tmp = *ptmp;
             buffers::string_buffer sb(