Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/obs deprecation dev #61

Merged
merged 14 commits into from
Feb 9, 2024
Merged

Feature/obs deprecation dev #61

merged 14 commits into from
Feb 9, 2024

Conversation

vinniefalco
Copy link
Member

No description provided.

@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

2 similar comments
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a8f7c92) 85.18% compared to head (c3f5073) 85.45%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #61      +/-   ##
===========================================
+ Coverage    85.18%   85.45%   +0.26%     
===========================================
  Files           77       77              
  Lines         4199     4269      +70     
===========================================
+ Hits          3577     3648      +71     
+ Misses         622      621       -1
Files Coverage Δ
include/boost/http_proto/fields.hpp 100.00% <ø> (ø)
include/boost/http_proto/fields_base.hpp 100.00% <100.00%> (ø)
include/boost/http_proto/impl/parser.hpp 81.81% <ø> (ø)
include/boost/http_proto/rfc/detail/rules.hpp 100.00% <ø> (ø)
src/error.cpp 92.98% <100.00%> (+0.12%) ⬆️
src/fields.cpp 100.00% <100.00%> (ø)
src/rfc/detail/rules.cpp 95.67% <100.00%> (+3.06%) ⬆️
src/request.cpp 75.00% <60.00%> (ø)
src/fields_base.cpp 93.33% <95.52%> (+0.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f7c92...c3f5073. Read the comment docs.

@cmazakas cmazakas force-pushed the feature/obs-deprecation-dev branch from b29a59e to bd8caab Compare January 30, 2024 21:31
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

vinniefalco
vinniefalco commented Jan 30, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Jan 30, 2024
View reviewed changes
src/rfc/detail/rules.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Jan 30, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
@cmazakas cmazakas force-pushed the feature/obs-deprecation-dev branch from bd8caab to 340e221 Compare January 31, 2024 20:07
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

vinniefalco
vinniefalco commented Jan 31, 2024
View reviewed changes
src/error.cpp
@@ -52,6 +51,7 @@ message(
case error::bad_expect: return "bad Expect";
case error::bad_field_name: return "bad field name";
case error::bad_field_value: return "bad field value";
case error::bad_field_smuggle: return "bad field smuggle";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still out of order alphabetically

vinniefalco
vinniefalco commented Jan 31, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Jan 31, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
@cmazakas cmazakas force-pushed the feature/obs-deprecation-dev branch from 340e221 to 0ff72c3 Compare February 1, 2024 20:33
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cmazakas cmazakas force-pushed the feature/obs-deprecation-dev branch from 0ff72c3 to 49f0fd9 Compare February 1, 2024 22:27
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

1 similar comment
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cmazakas cmazakas force-pushed the feature/obs-deprecation-dev branch from 3b3b02e to 9537c00 Compare February 6, 2024 23:18
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

vinniefalco
vinniefalco commented Feb 8, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Feb 8, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Feb 8, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Feb 8, 2024
View reviewed changes
src/fields_base.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Feb 8, 2024
View reviewed changes
src/rfc/detail/rules.cpp Outdated Show resolved Hide resolved
vinniefalco
vinniefalco commented Feb 8, 2024
View reviewed changes
test/unit/fields_base.cpp Outdated Show resolved Hide resolved
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@vinniefalco
Copy link
Member Author

This looks good now! Merge it when you feel it is ready

@cmazakas cmazakas force-pushed the feature/obs-deprecation-dev branch from 5633020 to c3f5073 Compare February 9, 2024 15:18
@cppalliance-bot
Copy link

GCOVR code coverage report https://61.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://61.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://61.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cmazakas cmazakas merged commit e1b4aa1 into cppalliance:develop Feb 9, 2024
53 checks passed
@cmazakas cmazakas deleted the feature/obs-deprecation-dev branch February 9, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinniefalco @cppalliance-bot @cmazakas