fix: buffer preparation in serializer #66
Conversation
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
4b4f15d to
c8755a1
Compare
ashtum
changed the title
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #66 +/- ##
===========================================
+ Coverage 85.45% 86.24% +0.78%
===========================================
Files 77 77
Lines 4269 4267 -2
===========================================
+ Hits 3648 3680 +32
+ Misses 621 587 -34
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
We're going to probably want to add a test case here that demonstrates the issue. |
|
I'm going to add tests for using serializer with a |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
c8755a1 to
fc47880
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
2 times, most recently
from
c50238f to
aec832d
Compare
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
aec832d to
8bf020e
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
8bf020e to
350ee7f
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
350ee7f to
78e65b1
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
78e65b1 to
af59fce
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
The test changes seemed good on paper but I'm not sure I understand the problem this code is solving because I can comment things and tests will still pass for me locally so I think I need some clarification on what's going on here and how we're fixing it. |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
af59fce to
e9c8eac
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
2 times, most recently
from
19ae51e to
acbb759
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
acbb759 to
517b08a
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
517b08a to
9ca2431
Compare
ashtum
force-pushed
the
fix-buffer-prepare-bug-in-serializer
branch
from
9ca2431 to
6dec1c6
Compare
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://66.http-proto.prtest.cppalliance.org/gcovr/index.html |
No description provided.