Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source a nested type of serializer #74

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Mar 19, 2024

No description provided.

#include <boost/http_proto/detail/array_of_buffers.hpp>
#include <boost/http_proto/detail/header.hpp>
#include <boost/http_proto/detail/workspace.hpp>
#include <boost/buffers/circular_buffer.hpp>
#include <boost/buffers/mutable_buffer_span.hpp>
#include <boost/buffers/range.hpp>
#include <boost/buffers/type_traits.hpp>
#include <boost/buffers/type_traits.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type traits twice?

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://74.http-proto.prtest.cppalliance.org/libs/http_proto/doc/html/index.html

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.09%. Comparing base (39a71bf) to head (ef7098e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #74   +/-   ##
========================================
  Coverage    88.09%   88.09%           
========================================
  Files           78       75    -3     
  Lines         4260     4260           
========================================
  Hits          3753     3753           
  Misses         507      507           
Files Coverage Δ
include/boost/http_proto/serializer.hpp 78.57% <100.00%> (+16.07%) ⬆️
src/serializer.cpp 74.89% <100.00%> (+2.37%) ⬆️
include/boost/http_proto/impl/serializer.hpp 95.74% <94.44%> (-0.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a71bf...ef7098e. Read the comment docs.

@ashtum
Copy link
Collaborator Author

ashtum commented Mar 19, 2024

Decided to keep the source in the namespace, as moving it to a nested type of serializer would cause every source type to include serializer.hpp.
Closes #70

@ashtum ashtum closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants