Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializer constructs source #77

Merged
merged 2 commits into from
Mar 22, 2024
Merged

serializer constructs source #77

merged 2 commits into from
Mar 22, 2024

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Mar 21, 2024

No description provided.

@ashtum ashtum force-pushed the pr/serializer-constructs-source branch from bfab1cb to d85b15c Compare March 21, 2024 17:20
@cppalliance-bot
Copy link

GCOVR code coverage report https://77.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://77.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://77.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (39a71bf) to head (f18a3a7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
- Coverage    88.09%   88.09%   -0.01%     
===========================================
  Files           78       78              
  Lines         4260     4257       -3     
===========================================
- Hits          3753     3750       -3     
  Misses         507      507
Files Coverage Δ
include/boost/http_proto/detail/impl/workspace.hpp 97.87% <100.00%> (ø)
include/boost/http_proto/detail/workspace.hpp 100.00% <ø> (ø)
include/boost/http_proto/impl/parser.hpp 80.00% <100.00%> (-1.82%) ⬇️
include/boost/http_proto/impl/serializer.hpp 96.42% <100.00%> (-0.13%) ⬇️
include/boost/http_proto/serializer.hpp 72.72% <100.00%> (+10.22%) ⬆️
include/boost/http_proto/source.hpp 100.00% <ø> (ø)
src/serializer.cpp 72.14% <ø> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a71bf...f18a3a7. Read the comment docs.

@cppalliance-bot
Copy link

GCOVR code coverage report https://77.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://77.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://77.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum force-pushed the pr/serializer-constructs-source branch 2 times, most recently from 870044f to 216d723 Compare March 22, 2024 15:54
@cppalliance-bot
Copy link

GCOVR code coverage report https://77.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://77.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://77.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum force-pushed the pr/serializer-constructs-source branch from 216d723 to 0f608ac Compare March 22, 2024 16:09
@ashtum ashtum force-pushed the pr/serializer-constructs-source branch from 0f608ac to bc52adc Compare March 22, 2024 16:11
@ashtum ashtum marked this pull request as ready for review March 22, 2024 16:11
@cppalliance-bot
Copy link

GCOVR code coverage report https://77.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://77.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://77.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://77.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://77.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://77.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

vinniefalco
vinniefalco reviewed Mar 22, 2024
View reviewed changes
include/boost/http_proto/impl/serializer.hpp
static_assert(
std::is_constructible<Source, Args...>::value ||
std::is_constructible<Source, buffered_base::allocator&, Args...>::value,
"The Source cannot be constructed with the given arguments");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@vinniefalco
Copy link
Member

This looks good

@cppalliance-bot
Copy link

GCOVR code coverage report https://77.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://77.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://77.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@ashtum ashtum merged commit 211cae2 into cppalliance:develop Mar 22, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmazakas cmazakas cmazakas left review comments

@vinniefalco vinniefalco vinniefalco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashtum @cppalliance-bot @vinniefalco @cmazakas