[#234] Empty line is supposed as stop for puzzle description #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pnatashap
commented
Jan 20, 2024
pnatashap
commented
- Empty comment line is supposed to be as end of the puzzle description
- If comment contains space symbol it is still considered as puzzle description
…At least one space in the line will read the next line also
|
@php-coder @yegor256 please take a look There is a separate issue about missing description for multiline puzzles, so haven't touched it yet #224 |
|
@rultor merge |
php-coder
reviewed
Jan 22, 2024
| ' | ||
| // TODO: #46 task description | ||
| // | ||
| // second line after empty line is a part of the puzzle in case of space exists |
There was a problem hiding this comment.
Line 145 also has a leading space after an empty line, but it isn't part of puzzle text. How this line is different?
There was a problem hiding this comment.
Oh, I see it now: on line 159 there is a trailing space.
Could we have a better rules for distinguishing one type of the comments from another? The current one seems like a subject for future confusions of our users.
/cc @yegor256 WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.