Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile for $apply response #343

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix profile for $apply response #343

merged 2 commits into from
Sep 15, 2023

Conversation

barhodes
Copy link
Contributor

Remove CPG Strategy profile from RequestGroups.
Only add to instantiatesCanonical the direct PlanDefinition that is being instantiated by a RequestGroup (not any nested PlanDefinitions)

…tiatesCanonical the direct PlanDefinition that is being instantiated
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Formatting check succeeded!

@JPercival JPercival enabled auto-merge (squash) September 15, 2023 17:53
@@ -5,11 +5,6 @@
{
"resourceType": "RequestGroup",
"id": "ChildRoutineVisit-PlanDefinition-1.0.0",
"meta": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What was the impetus for removing the profile? Just the fact that declaring your own profile is an anti-pattern in FHIR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that a resource can adhere to any number of profiles, it was decided that the calling source should be responsible for adding in and validating expected profiles.

@JPercival JPercival merged commit d06bd1a into master Sep 15, 2023
5 checks passed
@JPercival JPercival deleted the fix-profile-issues branch September 15, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants